Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix token used during both publish #823

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

g-ongenae
Copy link
Member

Description

Fix token used during both publish on NPM and GitHub Packages.

Motivation and Context

My previous PR #821 to add dual publish didn't work as expected.

It actually does not publish to NPM anymore. I infer this is because the NODE_AUTH_TOKEN is not uses correctly by lerna during the publish.

To fix that, we define the token and registry to use in the .npmrc file.

This was the method used to publish only on NPM.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@g-ongenae g-ongenae added the bug Something isn't working label Dec 6, 2023
@g-ongenae g-ongenae self-assigned this Dec 6, 2023
@g-ongenae g-ongenae merged commit 1f43a26 into algoan:master Dec 6, 2023
4 checks passed
@g-ongenae g-ongenae deleted the fixture/fix-dual-publish branch December 6, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants