Prioritize ICE transmits #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davibe
approved these changes
Jun 27, 2023
ICE transmits are infrequent, but more important than RTP traffic, therefore they should be prioritized highly when polling for output.
k0nserv
force-pushed
the
fix/prioritise-ice-traffic
branch
from
7ff32f8
to
02405df
Compare
algesten
previously approved these changes
Jun 27, 2023
|
I don't believe this will make any difference. The contract is to keep polling until timeout, which means whether you get ICE events before other events doesn't really matter. |
hmmmmmmmm. This is true |
algesten
requested changes
Jun 27, 2023
Yeah you're right, at best we send a bit earlier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICE transmits are infrequent, but more important than RTP traffic,
therefore they should be prioritized highly when polling for output.