Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Full EMOJI Support! 🎉 #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JLLeitschuh
Copy link

@JLLeitschuh JLLeitschuh commented Mar 17, 2023

Description

Adds a stringSpliterator function option to the Options

This allows custom string spliterators to be supported; as an example: https://www.npmjs.com/package/grapheme-splitter

Screen.Recording.2023-03-17.at.7.28.50.PM.mov

Signed-off-by: Jonathan Leitschuh [email protected]

Type of Change

[] It's a bug fix.
[x] It's a new feature (without breaking changes). [] It's a breaking change.

Checklist

Closes #343
Closes #208

  • Provided detailed description of the issue above.
  • Updated tests where appropriate.

License Agreement

  • By submitting this code, I'm aware that, if merged, it will be used as part of a commercial project. By submitting this pull request, I am aware that I'm giving my consent for my code to become a part of TypeIt or any of its related packages, and for it to be used and sold commercially.

Adds a `stringSpliterator` function option to the `Options`

This allows custom string spliterators to be supported;
as an example: https://www.npmjs.com/package/grapheme-splitter

Signed-off-by: Jonathan Leitschuh <[email protected]>
@JLLeitschuh
Copy link
Author

I think there may still be a bug somewhere with respect to delete(null). It's somehow losing track. Not sure what's up there.

@JLLeitschuh
Copy link
Author

I was using this lib to create a graphic for an OSS project, and I'm able to reproduce the issue.

See the comment // Using .delete() breaks the loop. Open Bug

https://codesandbox.io/s/openrewrite-graphic-ppid3m?file=/src/main.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant