Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed more readable #168

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

hareom284
Copy link

No description provided.

@JohnnyWalkerDigital
Copy link
Contributor

👎 Using the repository pattern with Laravel goes against its core ORM design

Copy link

@zawzawwin-dev zawzawwin-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think It it better approach

@JohnnyWalkerDigital
Copy link
Contributor

I think It it better approach

This is a good explanation as why it's not a good idea in 99.9% of Laravel projects

https://www.youtube.com/watch?v=giJcdfW2wC8

@carlos-mora
Copy link

In the context of Laravel, Repository provides the very same functionality and isolation than Eloquent Models do. Using it is duplicating behavior already present, and screwing up all the convention provided by an standard tool like Eloquent and the framework itself. Everybody knows Eloquent, it has a CONVENTION that a Repository will provide BY CONFIGURATION, following its own standards.

@carlos-mora
Copy link

I think It it better approach

What are you approaching to? :) Can you explain your POV?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants