-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domsdatabasen API #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
I've only got a few suggestions.
Also, I added a PR to merge in with your branch, which just updates the dependencies, Github workflows and such, since we haven't updated the repo in some time. No changes to your code in that PR, so it would be great if you could review that PR into this branch as well.
Chore/update deps and configs
I have merged your PR and made commits w.r.t your requested changes @saattrupdan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a small typo that was my mistake 🙂
Example usage
Fix #2