Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domsdatabasen API #5

Merged
merged 21 commits into from
Jul 17, 2024
Merged

Domsdatabasen API #5

merged 21 commits into from
Jul 17, 2024

Conversation

oliverkinch
Copy link
Collaborator

@oliverkinch oliverkinch commented Jul 11, 2024

Example usage

from alexandra_ai_data.domsdatabasen import Domsdatabasen

domsdatabasen = Domsdatabasen()

case = domsdatabasen.get_case(case_id="100")

print(case)

Fix #2

Copy link
Collaborator

@saattrupdan saattrupdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

I've only got a few suggestions.

Also, I added a PR to merge in with your branch, which just updates the dependencies, Github workflows and such, since we haven't updated the repo in some time. No changes to your code in that PR, so it would be great if you could review that PR into this branch as well.

src/alexandra_ai_data/domsdatabasen.py Outdated Show resolved Hide resolved
src/alexandra_ai_data/domsdatabasen.py Show resolved Hide resolved
src/alexandra_ai_data/domsdatabasen.py Outdated Show resolved Hide resolved
src/alexandra_ai_data/domsdatabasen.py Outdated Show resolved Hide resolved
src/scripts/domsdatabasen_example_usage.py Outdated Show resolved Hide resolved
@oliverkinch
Copy link
Collaborator Author

I have merged your PR and made commits w.r.t your requested changes @saattrupdan

Copy link
Collaborator

@saattrupdan saattrupdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a small typo that was my mistake 🙂

makefile Show resolved Hide resolved
@saattrupdan saattrupdan merged commit 33edefd into main Jul 17, 2024
4 checks passed
@saattrupdan saattrupdan deleted the domsdatabasen branch July 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support data from domsdatabasen
2 participants