-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display start and last updated timestamp on system status page #3788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a small change!
bf4c974
to
81bcc73
Compare
@Rosencrantz I’ve pushed a small update. When testing this with a few larger datasets, I found that the relative times would add a lot of noise. Specifically:
Instead, I’m now displaying just the absolute time (if the date is today) or otherwise the date and time: |
This can be merged as soon as alephdata/servicelayer#190 is released |
Nioce update. I approve! |
With relative times, when looking at a full status page, there will be a lot of numbers that are constantly updated. For example, even if "last updated" hasn’t changed, how it is rendered will change over time (from "last updated now" to "last updated 5 seconds ago" etc.) In addition, the different lengths of the rendered strings can cause layout shifts/line breaks. This makes it more difficult to track a specific row and to identify values that have actually changed. Instead, I’m now displaying the absolute time (if the day is today) or the absolute date and time. This leads to a slightly less cluttered and noisy UI.
81bcc73
to
e6a4dde
Compare
This exposes the two timestamps (that are already returned per collection by the status API) in the UI. Times are relative (for example "45 seconds ago"), but hovering over them displays the full date/time (for example "Fri, Jun 28, 2024, 5:05 PM").
Todos: