Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "release/3.17.0" into "develop" #3749

Merged
merged 42 commits into from
May 28, 2024
Merged

Merge "release/3.17.0" into "develop" #3749

merged 42 commits into from
May 28, 2024

Conversation

tillprochaska
Copy link
Contributor

No description provided.

catileptic and others added 30 commits January 23, 2024 17:25
Don't rename existing collections when running crawldir
update the link to memorious
* Temporarily remove registration video tutorial

… until we have an updated version.

* Update instructions on how to manage accounts on aleph.occrp.org

* I’ve created two separate pages for "How to create an account" and "How to reset your password" to improve discoverability clarity.
* I’ve updated all screenshots and instructions to properly reflect the current registration process.

* Fix misc issues in account FAQ

* Fixed typos
* Updated broken links
Something went wrong during the 3.15.5 release and as a consequence starting Aleph with the Docker Compose configuration from the main branch doesn’t work. Once we’ve published a fixed release we can remove this line again.
Previously, these tables were not dropped after test executions. In some edge cases, this could lead to unexpected test failures. For example, Aleph reindexes a collection from ftmstore after executing a mapping. In that case, entities written to the same ftmstore table in a previous test would end up in the ES index.
Playwright fixes (cherry-picked from develop)
Transifex URL changed - adjusted accordingly
dependabot bot and others added 10 commits May 22, 2024 16:41
* Bump react-pdf from 5.7.2 to 7.7.3 in /ui

Bumps [react-pdf](https://github.com/wojtekmaj/react-pdf/tree/HEAD/packages/react-pdf) from 5.7.2 to 7.7.3.
- [Release notes](https://github.com/wojtekmaj/react-pdf/releases)
- [Commits](https://github.com/wojtekmaj/react-pdf/commits/v7.7.3/packages/react-pdf)

---
updated-dependencies:
- dependency-name: react-pdf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix alignment of invisible text layer

The text layer is what makes text selectable, but it needs to be aligned in the same way as the underlying canvas that renders the page.

* Do not render annotations

Annotations can be popups, notes, highlights, forms, or clickable links. We currently do not render annotations. While the use of the `renderAnnotations` property suggests that annotations were indeed enabled in an earlier version, the property has been renamed long time ago and annotations have (effectively) not been enabled for multiple years now.

While it would have been possible to enable annotations again, I think keeping them disabled is actually sensible as they bear some risk due to their interactive nature.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Till Prochaska <[email protected]>
* Ensure that end-to-end test run in CI

The `docker compose run` command doesn’t support the `--build-arg` argument. Depending on the Docker Compose version installed, using the `--build-arg` argument would either exit with an error code or simply print the command help.

To achieve the desired outcome, we can first build the image with the build argument, then start the container. This has the additional advantage of separating the build logs from the logs of the actual command execution in the GitHub Actions UI.

* Pull and start services before running tests

This separates logs related to pulling/starting service containers from the logs of the actual test command.
This command override is not required anymore because the default command specified in the Dockerfile now has the correct command. We only added it back temporarily due to a release issue. See ed017fa.
The PDF.js worker is dynamically loaded by PDF.js at runtime. The version of PDF.js in the main app bundle and of the worker have to be in sync. Previously, we simply copied the worker file to a static location (`/static/pdf.worker.min.js`). When updating PDF.js, this might cause problems if the worker file is still cached by browsers.

Instead of manually copying the file, we now make use of Webpack’s support for external assets[1]. Webpack copies the file to the build directory during the build step. It also appends a hash based on the file contents to the file name, e.g. `pdf.worker.min.2b1fcb1d45631a4dd93a.js` to ensure that browsers do not load a cached version when the worker has been updated.

[1]: https://webpack.js.org/guides/asset-modules/#url-assets
@tillprochaska tillprochaska changed the title Release/3.17.0 Merge "release/3.17.0" into "develop" May 27, 2024
@tillprochaska tillprochaska marked this pull request as ready for review May 28, 2024 09:20
@tillprochaska tillprochaska merged commit 9e0f4fa into develop May 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants