Hotfix: multi token highlights #3275 #3278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I propose removing the Seems more clean to me compared to first creating the |
|
I like the suggestion from #3280 a little bit better as well, as it makes it a bit more obvious what is going on. My suggestion is to merge that and see how it works in our staging environment. |
|
Fields array has been removed from the highlight queries now as per #3280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue discussed here: #3275
As discussed, the origin of this bug and why this one-liner fixes it are not fully investigated, nor are some side-effects.
First experiences in a running production environment are positive.