fix: [ALC-LA2-2] revert on malformed signature #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
force-pushed
the
04-04-fix_ALC-LA2-2_revert_on_malformed_signature
branch
from
ebc685a
to
d9eb605
Compare
jaypaik
force-pushed
the
04-04-fix_ALC-LA2-2_revert_on_malformed_signature
branch
from
d9eb605
to
8c5c85d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert instead of returning
SIG_VALIDATION_FAILEDfor malformed signatures. Note that this also impacts the ERC-1271isValidSignatureflow to revert when the trimmed signature is malformed. This is not prohibited by ERC-1271, so this is fine.