Support For DRF 3.15 nested SimpleRouter.use_regex_path = False #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address the following issue:
#342
In order to properly use use_regex_path=False for the simple router you must have DRF 3.15+. If the kwarg is passed and an earlier version of DRF is used it should simply TypeError due to the unexpected kwarg . If this requires a read-me update for notes around Requirements & Compatibility let me know what you would like to see there and I can add it.
The changes are the same as suggested in #342 and are explained in more detail there. The changes are essentially changing how we pre-pend the parent url when use_regex_path=False, allowing it to correctly nest the routes. I also added a unit test validating the changes.
Please let me know if you have any concerns or questions!