Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test http server to CR #158

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Add test http server to CR #158

merged 2 commits into from
Dec 4, 2023

Conversation

sgreenbury
Copy link
Collaborator

@sgreenbury sgreenbury commented Nov 29, 2023 •
edited
Loading

This combines initial #157 with #94 so that a single test server is run on 127.0.0.1:8081 as part of cargo test.

thobson88
thobson88 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@thobson88 thobson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only comment is that we should move the large test fixtures out of resolver.rs at some point.

@sgreenbury sgreenbury merged commit 44dfaf2 into 94-cr-cli Dec 4, 2023
@sgreenbury sgreenbury deleted the 94-cr-cli-test-http-server branch December 4, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thobson88 thobson88 thobson88 approved these changes

@pwochner pwochner Awaiting requested review from pwochner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgreenbury @thobson88