Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JavaScript function to its own file #7

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Conversation

Iain-S
Copy link
Contributor

@Iain-S Iain-S commented Aug 15, 2023

Move some JavaScript to its own .js file. This makes it easier to get syntax highlighting and easier to lint the JS.

See https://eslint.org/docs/latest/ for a thorough description of all rules.

Refactor how the details page RBAC list is sorted so that it isn't O(n*m).

@Iain-S Iain-S added the WIP Work In Progress (do not merge) label Aug 16, 2023
@Iain-S Iain-S removed the WIP Work In Progress (do not merge) label Nov 16, 2023
rctab/routers/frontend.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dlpbc dlpbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to merge in.

@dlpbc dlpbc merged commit b8821af into main Dec 7, 2023
5 checks passed
@dlpbc dlpbc deleted the mv-js-to-own-file branch December 7, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants