Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Styles / Scripts #32

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Inline Styles / Scripts #32

merged 7 commits into from
Dec 11, 2023

Conversation

Iain-S
Copy link
Contributor

@Iain-S Iain-S commented Dec 7, 2023 •
edited
Loading

  • There are inline CSS and JS elements on the details page that we didn't pick up when first adding the CSP.
  • I had neglected to add a JS file to version control when refactoring.
  • Use of async JS funcs requires change to eslint settings.
  • Missing RBAC assignments would cause internal server error on details page.
  • Add details page rendering unit test.
  • Empty permissions policy caused Error with Permissions-Policy header: Parse of permissions policy failed because of errors reported by structured header parser. in Chrome

dlpbc
dlpbc approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@dlpbc dlpbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!
All looks good to me.

@Iain-S Iain-S merged commit 0ff77a1 into main Dec 11, 2023
5 checks passed
@Iain-S Iain-S deleted the csp branch December 11, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlpbc dlpbc dlpbc approved these changes

@joseph-palmer joseph-palmer Awaiting requested review from joseph-palmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iain-S @dlpbc