-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use celery to schedule periodic tasks #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iain-S
added
WIP
Work In Progress (do not merge)
and removed
WIP
Work In Progress (do not merge)
labels
Nov 22, 2023
Iain-S
commented
Nov 27, 2023
Iain-S
added
WIP
Work In Progress (do not merge)
and removed
WIP
Work In Progress (do not merge)
labels
Nov 27, 2023
joseph-palmer
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we add more periodic tasks (e.g. if we add usage forecasting in addition to the existing abolishments and daily emails), switching to a more widely used task management option makes sense.
Celery is a task queue, which requires a broker to mediate between clients and workers and, optionally, a backend for result storage. I have used Redis as the broker as it was easier to install than Rabbit MQ. Since we don't do anything with the results of completed tasks, I have omitted a backend but we could use Redis or Postgres if we need one in the future.
ToDo
UUID(int=0)
.Europe/London
timezone?Shut down redis and celery on exit (particularly if using the runtests script.