Merge pull request #15 from alan-turing-institute/fix-bug-summary-emails

Remove unneeded sorting.
alan-turing-institute · Aug 31, 2023 · 4c76dc6 · 4c76dc6
2 parents 004308b + 2aa49b1
commit 4c76dc6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "RCTab"
-version = "1.1.0"
+version = "1.1.1"
 description = "The RCTab API. Manage Azure budgets and usage"
 authors = []
 

diff --git a/rctab/routers/accounting/send_emails.py b/rctab/routers/accounting/send_emails.py
@@ -741,7 +741,6 @@ async def get_emails_sent_since(
     )
     rows = await database.fetch_all(emails_query)
     all_emails_sent: List[dict] = [{**row._mapping} for row in rows]
-    all_emails_sent = sorted(all_emails_sent, key=extract_sub_id)
 
     emails_by_subscription = []
     for key, value in groupby(all_emails_sent, extract_sub_id):
@@ -784,7 +783,6 @@ async def get_finance_entries_since(
     )
     rows = await database.fetch_all(finance_query)
     all_new_entries = [{**row._mapping} for row in rows]
-    all_new_entries = sorted(all_new_entries, key=extract_sub_id)
     entries_by_subscription = []
     for key, value in groupby(all_new_entries, extract_sub_id):
         name_query = select([subscription_details.c.display_name.label("name")]).where(