Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release v5.0.1 into develop #2258

Merged
merged 59 commits into from
Oct 24, 2024
Merged

Merge release v5.0.1 into develop #2258

merged 59 commits into from
Oct 24, 2024

Conversation

JimMadge
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

🌂 Related issues

🔬 Tests

jemrobinson and others added 30 commits October 7, 2024 15:28
Use SHM name instead of description for Entra app
Unchangable Pulumi workspace configuration
jemrobinson and others added 24 commits October 23, 2024 20:00
Management documentation updates
@JimMadge JimMadge requested review from a team as code owners October 24, 2024 13:11
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven
  version.py
  data_safe_haven/commands
  sre.py
  data_safe_haven/config
  context.py
  data_safe_haven/external/api
  graph_api.py 1058-1072
  data_safe_haven/external/interface
  pulumi_account.py
  data_safe_haven/infrastructure
  project_manager.py 163-164
  data_safe_haven/infrastructure/programs
  imperative_shm.py 160
Project Total  

This report was generated by python-coverage-comment-action

@JimMadge JimMadge merged commit 67d5ace into develop Oct 24, 2024
11 checks passed
@JimMadge JimMadge deleted the merge_release branch October 24, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants