-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Pulumi to create Entra applications #2248
Open
jemrobinson
wants to merge
12
commits into
alan-turing-institute:develop
Choose a base branch
from
jemrobinson:2215-create-entra-applications-with-pulumi
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use Pulumi to create Entra applications #2248
jemrobinson
wants to merge
12
commits into
alan-turing-institute:develop
from
jemrobinson:2215-create-entra-applications-with-pulumi
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
jemrobinson
changed the title
Use Pulumi to create Entra applications
WIP Use Pulumi to create Entra applications
Oct 22, 2024
jemrobinson
force-pushed
the
2215-create-entra-applications-with-pulumi
branch
from
October 23, 2024 19:30
b76de51
to
4d7ff34
Compare
jemrobinson
changed the title
WIP Use Pulumi to create Entra applications
Use Pulumi to create Entra applications
Oct 23, 2024
…e used to seed the pulumi-azuread provider
jemrobinson
force-pushed
the
2215-create-entra-applications-with-pulumi
branch
from
October 25, 2024 09:22
d211fe6
to
810d86e
Compare
…s since these set the provider information in the state file and cannot be changed
jemrobinson
force-pushed
the
2215-create-entra-applications-with-pulumi
branch
from
October 25, 2024 09:41
59078dd
to
3d5f21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.🚦 Depends on
n/a
Replace creation of SRE Entra applications through the SDK with creation through
pulumi-azuread
.Note we still need one SDK-created Entra application in the SHM which is used to authenticate
pulumi-azuread
.The
msgraph_permissions
map looks up the GUIDs for all possible permissions. We could consider replacing this with a static lookup table that only covers the ones we need.🌂 Related issues
Closes #2215
🔬 Tests
Tested on a fresh SRE deployment