Use SHM name instead of description for Entra app

[craddm]

✅ Checklist

• You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
• You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
• Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Uses the SHM/context name as part of the name of the Entra application, instead of the description.

This ensures the application will have a consistent name.

🌂 Related issues

Closes #2242

🔬 Tests

Tested locally

[jemrobinson]

LGTM. Nice catch.

[jemrobinson]

N.B. Should this target 5.0.1-rc1 instead of develop? Sounds like a bugfix we will want in the patch release.

[craddm]

N.B. Should this target 5.0.1-rc1 instead of develop? Sounds like a bugfix we will want in the patch release.

Could do; but depends if we're merging develop into 5.0.1-rc1, as this is up-to-date with develop rather than based on 5.0.1-rc1

[jemrobinson]

@craddm : Sorry, for this to work you should probably grab that single commit and apply it on top of release-v5.0.1rc1.

[JimMadge]

Could you check for other places where the description is used?

It isn't ideal that it lives in the context but I think we should ensure changing it doesn't produce any destructive operations.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/config
context.py
Project Total

This report was generated by python-coverage-comment-action

[craddm]

Could you check for other places where the description is used?

It isn't ideal that it lives in the context but I think we should ensure changing it doesn't produce any destructive operations.

I haven't spotted anywhere else - every other use I've found is just for information (e.g. printing messages to console)