-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch config upload validation errors #2211
Catch config upload validation errors #2211
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think the output here is clearer than before.
@craddm we could also add a couple of tests here
- To ensure a config problem give the human-friendly error
- To check the format of the exception in
yaml_serialisable_model.py
Looks like a test is trying to use az CLI. Maybe a missing mock fixture. |
Yes - odd as it was working before we changed things today, and the only thing we changed which touches this test is how the yaml with the missing field is made. |
Might be due to a change on develop that was merged in? |
Nope - just tested it out. It works fine if I revert the change in how |
Hmm 🤔 something about how the |
Or, the change from missing value to missing field has changed what is happening underneath? |
In any case, you should be able to follow the traceback (or code) to find out what is happening. |
We just weren't doing it correctly, so the |
Oh, that is brilliant. We were too good at not writing bad YAML 😆. |
567d30e
into
alan-turing-institute:develop
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.🚦 Depends on
Catches an exception when trying to upload an invalid config file and exits cleanly. Also improves the related error message to make it clearer what the validation error is.
Original error message:
Catches the error cleanly and yields a clearer error message
🌂 Related issues
Closes #2210
🔬 Tests
Tested locally