Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulumi: Lazy load Guacamole users when performing admin tasks #1568

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Aug 24, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

Minor QOL fix to lazy-load GuacamoleUsers rather than loading users for all SREs everytime we do any user operation.

🌂 Related issues

Closes #1569

🔬 Tests

Tested locally

@jemrobinson jemrobinson changed the base branch from develop to python-migration August 24, 2023 16:30
@jemrobinson jemrobinson requested a review from a team August 24, 2023 16:31
@jemrobinson jemrobinson changed the title Lazy load Guacamole users when performing admin tasks Pulumi: Lazy load Guacamole users when performing admin tasks Aug 24, 2023
@jemrobinson jemrobinson merged commit 7c0022b into alan-turing-institute:python-migration Aug 25, 2023
10 checks passed
@jemrobinson jemrobinson deleted the lazy-load-guacamole-users branch April 19, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant