-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulumi: SRE DNS filtering #1566
Merged
JimMadge
merged 33 commits into
alan-turing-institute:python-migration
from
jemrobinson:1504-dns-filtering
Aug 30, 2023
Merged
Pulumi: SRE DNS filtering #1566
JimMadge
merged 33 commits into
alan-turing-institute:python-migration
from
jemrobinson:1504-dns-filtering
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allow DNS server to resolve zone entries
… easier debugging
jemrobinson
force-pushed
the
1504-dns-filtering
branch
from
August 22, 2023 15:52
e5a28b2
to
b3bcc51
Compare
…e by Azure Container Instances
… from an input string
jemrobinson
force-pushed
the
1504-dns-filtering
branch
from
August 24, 2023 17:25
6de1717
to
b45d76a
Compare
…ationGateway which requires specific rules
jemrobinson
force-pushed
the
1504-dns-filtering
branch
from
August 25, 2023 09:55
90cf0f9
to
1a9213f
Compare
5 tasks
jemrobinson
force-pushed
the
1504-dns-filtering
branch
3 times, most recently
from
August 25, 2023 16:09
0f83f60
to
8e8118a
Compare
jemrobinson
force-pushed
the
1504-dns-filtering
branch
2 times, most recently
from
August 29, 2023 11:53
1fd4a68
to
bb289e3
Compare
JimMadge
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few questions mostly.
Co-authored-by: Jim Madge <[email protected]>
Co-authored-by: Jim Madge <[email protected]>
jemrobinson
force-pushed
the
1504-dns-filtering
branch
2 times, most recently
from
August 30, 2023 08:23
fa492d7
to
774372e
Compare
jemrobinson
force-pushed
the
1504-dns-filtering
branch
2 times, most recently
from
August 30, 2023 08:30
8267929
to
1562a19
Compare
jemrobinson
force-pushed
the
1504-dns-filtering
branch
from
August 30, 2023 08:41
1562a19
to
56e7b8e
Compare
JimMadge
approved these changes
Aug 30, 2023
JimMadge
merged commit Aug 30, 2023
cacd39d
into
alan-turing-institute:python-migration
6 checks passed
9 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.'[WIP]'
to the title if needed (if you're not yet ready to merge)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>
for Powershell).🌂 Related issues
Closes #1504
🔬 Tests
DNS lookup restrictions are working