-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulumi: Migrate pyproject to PyPA standard and hatch #1506
Conversation
@jemrobinson This is not ready for review yet but would like your thoughts. Especially on how to merge this (if we want to) without disrupting other work on the pulumi branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly happy but a few questions on details. Also, we should check for compatibility with #1509 which adds some dependencies.
I think this and #1509 can be merged in either order. Just need to be aware that they are inter-dependent. |
No, because I'll need to fix all the black and ruff errors to not break CI in main. That will involve touching (potentially) every Python file in the repo. That's why I want other work on this branch to stop before I start fixing the linting errors. Resolving merge conflicts will be too difficult otherwise. |
In line with previous practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typer
requires Optional[type]
rather than type | None
. Otherwise you get the message:
RuntimeError: Type not yet supported: str | None
Typer does not support newer union syntax fastapi/typer#522 Co-authored-by: James Robinson <[email protected]>
c4fe081
to
18c7732
Compare
Co-authored-by: James Robinson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by redeploying an SHM and SRE.
…dgeDocServerComponent calls
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.'[WIP]'
to the title if needed (if you're not yet ready to merge)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>
for Powershell).Migrate to hatch/hatchling.
🌂 Related issues
Check #1510 before merging
🔬 Tests