Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change allowed FQDN for ADConnect endpoints #1505

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Change allowed FQDN for ADConnect endpoints #1505

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d04a55f
remove FQDN for AADconnect endpoints
craddm Jul 14, 2023
e412f00
Ensure script uses correct VM name
craddm Jul 21, 2023
15bab0f
Pass RG name directly rather than use logical
craddm Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions deployment/secure_research_environment/setup/Configure_External_DNS_Queries.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ $allowedFqdns = @($firewallRules.applicationRuleCollections | ForEach-Object { $
@(Get-PrivateDnsZones -ResourceGroupName $config.shm.network.vnet.rg -SubscriptionName $config.shm.subscriptionName | ForEach-Object { $_.Name })
# List all unique FQDNs
$allowedFqdns = $allowedFqdns |
Where-Object { $_ -notlike "g*.servicebus.windows.net" } | # Remove AzureADConnect password reset endpoints
Where-Object { $_ -notlike "*-sb.servicebus.windows.net" } | # Remove AzureADConnect password reset endpoints
Where-Object { $_ -notlike "pksproddatastore*.blob.core.windows.net" } | # Remove AzureAD operations endpoints
Sort-Object -Unique
Add-LogMessage -Level Info "Restricted networks will be allowed to run DNS lookup on the following $($allowedFqdns.Count) FQDNs:"
Expand Down Expand Up @@ -81,7 +81,8 @@ Add-LogMessage -Level Info "Looking for SRD with IP address '$vmIpAddress'..."
if (-not $vmIpAddress) {
Add-LogMessage -Level Fatal "No SRD found with IP address '$vmIpAddress'. Cannot run test to confirm external DNS resolution."
} else {
$vmName = @(Get-AzNetworkInterface | Where-Object { $_.IpConfigurations.PrivateIpAddress -eq $vmIpAddress } | ForEach-Object { $_.VirtualMachine.Id.Split("/")[-1] })[0]
# Match on IP address within approriate SRE resource group
$vmName = @(Get-AzNetworkInterface -ResourceGroupName $config.sre.srd.rg | Where-Object { $_.IpConfigurations.PrivateIpAddress -eq $vmIpAddress } | ForEach-Object { $_.VirtualMachine.Id.Split("/")[-1] })[0]
Add-LogMessage -Level Info "Testing external DNS resolution on VM '$vmName'..."
$params = @{
SHM_DOMAIN_FQDN = $config.shm.domain.fqdn
Expand Down
Loading