Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assessment notebook for December workshop #97

Closed
wants to merge 55 commits into from
Closed

Assessment notebook for December workshop #97

wants to merge 55 commits into from

Conversation

gmingas
Copy link
Collaborator

@gmingas gmingas commented Dec 5, 2023

No description provided.

@RuthBowyer
Renaming file for better accuracy
7dd6114 
Adding WIP markdowns
@RuthBowyer
Renaming file for clarity
6d8875b
@RuthBowyer
Updating func and appling BC qmapQuant to three cities
e9f7a85
@RuthBowyer
Moving some files to new folder
687eb12
@RuthBowyer
Script updates for grouping etc
05ad4c9
@RuthBowyer
Correcting precip error in Hads read in
1695c31
@RuthBowyer
Correcting precip error in Hads read in
ad2845b
@RuthBowyer
Merge branch 'LCAT.data' of https://github.com/alan-turing-institute/…
17cca21 
…clim-recal into LCAT.data
@RuthBowyer
Updating fnc for scotland
b77383f
@RuthBowyer
Updating fnc for scotland
0c828f7
@RuthBowyer
Start the BC for LCAT
fd5642b 
Merge branch 'LCAT.data' of https://github.com/alan-turing-institute/clim-recal into LCAT.data

# Conflicts:
#	R/bias-correction-methods/apply_qmapQuant_to_crpd_df_fn.R
@RuthBowyer
Including fnc for Scotland
470fb08
@RuthBowyer
Deriving seasonal means
dff994f
@RuthBowyer
Loading obs data
c15beab
@RuthBowyer
Simplifying code - this might be a conflict later though
89df88e
@RuthBowyer
Adding metrics, sorting out fig generation
b195855
@RuthBowyer
Adding in all runs rather than one and extracting rasters for general…
4e8be76 
… assesment
@RuthBowyer
Adding loops to deal with the four runs simultaneously
049e749
@RuthBowyer
Updating with more figs
5791e97
@RuthBowyer
conversion of val dfs to run over all runs
bd9d793
@RuthBowyer
update read_crop.fn.R - this could have been pushed already?
894efea
@RuthBowyer
Added density plot, rmse for each run
68d7aca
@RuthBowyer
Cleaning up files for LCAT
282a75e
@RuthBowyer
Updates for R pipeline
f90ac12
@RuthBowyer
Adding pre-processing to within method (qmap in this eg)
be16f8f 
Removing files no longer needed
@RuthBowyer
Sep'ing script for conversion to df
879e608
@RuthBowyer
updating for easier R pipeline
44175ac
@RuthBowyer
Update to script to convert city crops to data frame
4ca30d4
@RuthBowyer
Add notes and fixing function
580d36f
@RuthBowyer
Small updated to wet.day and corrected related issue preventing run
2e6fa1d
RuthBowyer and others added 22 commits October 9, 2023 08:23
@RuthBowyer
Updating metrics so as to work with new data format
972502d
@RuthBowyer
tidy markdown add kable
ad8851f
@spool
merge: attempt fixing main and Update.Rpipeline merge conflict
cf7be9f
@spool
fix(ci): add pre-commit to check R/ path and apply
6049fca
@spool
feat: add notebooks/Assessing_bc_Data_local-mac.rmd
a704f7c
@spool
fix(ci): apply pre-commit change to remainder of R/
30ab294
@spool
feat: add notebooks/Assessing_bc_Data/Assessing_BC-Data-workshop.RMD
0de11c3
@spool
feat(refactor): comment out python vs R loading options in `Asses…
4ddee59 
…sing...-workshop.RMD`
@spool
refactor(debias): add debias_wrapper.py for potential new python re…
4e8f1d0 
…sults
@spool
feat: add RuthUpdates...Rmd notebook
7bd7787
@spool
fix(ci): merge main CI changes
fc63a17
@spool
Merge remote-tracking branch 'origin/workshop-python-rerun' into ruth…
eea965f 
…-notebook-for-workshop
@gmingas
Automate installation of packages
55ecdf8
@gmingas
Minor modifications in install and import order
eec0e56
@gmingas
Remove duplicate library call
ad405cf
@RuthBowyer
Adding in the index to look up
98f03cb 
Testing for conflicts
@gmingas
Recommit installation cell that was overwritten
f7a2803
@RuthBowyer
Final notebook that knits
3b141c7
@RuthBowyer
adding html rendered notebook
76048fd
@RuthBowyer
small change to format
f0de8eb
@spool
feat: add rstudio docker deploy and python.utils.make_user
42d8d23
@spool
Merge remote-tracking branch 'origin/ruth-notebook-for-workshop' into…
50e8d1f 
… ruth-notebook-for-workshop
@griff-rees griff-rees mentioned this pull request Jan 4, 2024
Closed
10 tasks
@griff-rees griff-rees mentioned this pull request Jan 11, 2024
Closed
2 tasks
This was referenced Jan 18, 2024
Closed
Open
andrewphilipsmith
andrewphilipsmith reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@andrewphilipsmith andrewphilipsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the non-R code so far (eg python and config files).

There are a couple of things that I think need to be addressed. I've added in-line comments for these.

I'll add more comments as I get to them.

compose/server/Dockerfile Show resolved Hide resolved
compose/server/Dockerfile Show resolved Hide resolved
python/debiasing/debias_wrapper.py Show resolved Hide resolved
python/debiasing/debias_wrapper.py Show resolved Hide resolved
python/utils.py Show resolved Hide resolved
@griff-rees
Copy link
Collaborator

All comments addressed in #122

@griff-rees griff-rees closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewphilipsmith andrewphilipsmith andrewphilipsmith left review comments

@griff-rees griff-rees griff-rees left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gmingas @griff-rees @andrewphilipsmith @RuthBowyer @spool