Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix of quartodoc CI rendering #134

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Partial fix of quartodoc CI rendering #134

merged 5 commits into from
Feb 26, 2024

Conversation

griff-rees
Copy link
Collaborator

@griff-rees griff-rees commented Feb 13, 2024

This partially addresses #128 but may only render one quartodoc page correctly. I thought it nice to sort this for tomorrow.

@griff-rees griff-rees added bug Something isn't working documentation Improvements or additions to documentation labels Feb 14, 2024
Copy link
Collaborator

@andrewphilipsmith andrewphilipsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As far as I can tell, this brings nearly all references to the Python version in line at version "3.10". The one exception I can find is in docs/contributing.md. It would be worth double-checking that there are no remaining references to 3.9.

Otherwise good to merge.

@griff-rees griff-rees merged commit 2e62759 into main Feb 26, 2024
6 checks passed
@griff-rees griff-rees deleted the fix-quartodoc branch February 26, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants