Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names #250

Merged
merged 25 commits into from
Sep 27, 2024
Merged

Names #250

merged 25 commits into from
Sep 27, 2024

Conversation

mastoffel
Copy link
Collaborator

  • lots of renaming
  • lots of re-structuring
  • new tests

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate
  compare.py 315, 317, 320, 338-345, 359-360, 463
  cross_validate.py 152
  metrics.py
  model_processing.py
  model_registry.py
  plotting.py 133
  printing.py 97
  save.py 32-34
  utils.py
  tests
  test_compare.py
  test_cross_validate.py 56-59, 64
  test_model_registry.py
  test_plotting.py
  test_printing.py
  test_save.py
  test_ui.py
  test_utils.py
Project Total  

This report was generated by python-coverage-comment-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.26923% with 21 lines in your changes missing coverage. Please review.

Project coverage is 93.82%. Comparing base (e823a63) to head (cdbd727).

Files with missing lines Patch % Lines
autoemulate/compare.py 70.73% 12 Missing ⚠️
autoemulate/save.py 90.00% 3 Missing ⚠️
tests/test_cross_validate.py 95.83% 3 Missing ⚠️
autoemulate/cross_validate.py 96.00% 1 Missing ⚠️
autoemulate/plotting.py 85.71% 1 Missing ⚠️
autoemulate/printing.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   94.00%   93.82%   -0.18%     
==========================================
  Files          48       48              
  Lines        2803     2755      -48     
==========================================
- Hits         2635     2585      -50     
- Misses        168      170       +2     
Flag Coverage Δ
93.82% <93.26%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mastoffel mastoffel merged commit 0c996af into main Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants