Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new branch web-app #11

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Create new branch web-app #11

merged 2 commits into from
Jun 10, 2021

Conversation

supzi-del
Copy link
Contributor

@supzi-del supzi-del commented Jun 10, 2021 •
edited by akshitadixit
Loading

closes #7

Is this okay?

@supzi-del supzi-del mentioned this pull request Jun 10, 2021
Closed
akshitadixit
akshitadixit requested changes Jun 10, 2021
View reviewed changes
Copy link
Owner

@akshitadixit akshitadixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @supzi-del everything is okay, just that you forgot to add the fresh README.md file mentioned in #7
Please add that and push it. The changes will be reflected in this PR.

@akshitadixit akshitadixit added LGMSOC21 This issue will be considered for LGM-SOC 21 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21.Points will be 10 labels Jun 10, 2021
@supzi-del
Copy link
Contributor Author

Oh okay, where should I add it?

@supzi-del
Copy link
Contributor Author

I have created a folder called README.md in the folder of VCallZer. What should I do next?

@akshitadixit
Copy link
Owner

Oh okay, where should I add it?

In the web-app branch

@akshitadixit
Copy link
Owner

I have created a folder called README.md in the folder of VCallZer. What should I do next?

Commit the file and push to your repo using git push web-app and your changes will automatically be seen here

akshitadixit
akshitadixit approved these changes Jun 10, 2021
View reviewed changes
Copy link
Owner

@akshitadixit akshitadixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@akshitadixit akshitadixit merged commit bfc784d into akshitadixit:main Jun 10, 2021
@supzi-del
Copy link
Contributor Author

Thanks for guiding!

@akshitadixit
Copy link
Owner

@supzi-del you're welcome, just make sure the next time you make a PR use the words closes or fixes with the issue number as I edited in your description above. This automatically links the issue and closes it when the PR is merged. Just some good open-source practice :)

@akshitadixit akshitadixit mentioned this pull request Jun 10, 2021
Merged
@supzi-del
Copy link
Contributor Author

Hey! did anything go wrong from my side?

@akshitadixit
Copy link
Owner

Hey! did anything go wrong from my side?

Hey @supzi-del I forgot to check the merge destination.
The next time you push a new branch to a repo, please do not select the destination as main. I did overlook this, my bad.
image

@supzi-del
Copy link
Contributor Author

I'm so sorry! I will keep it in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshitadixit akshitadixit akshitadixit approved these changes

Assignees
No one assigned
Labels
🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21.Points will be 10 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new branch
2 participants
@supzi-del @akshitadixit