Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix Plugin: Correctly support multiple endpoints #254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joshk
Copy link
Contributor

@joshk joshk commented Sep 15, 2024

Change description

The current logic for the keep_endpoint_metrics function doesn't work for cases where multiple endpoints are configured using the endpoints: key.

This change normalizes the endpoints config to work with module in phoenix_endpoints

What problem does this solve?

The events defined in the endpoint_info function weren't working as expected, as the keep_function_filter returned false. This started happening after I tested out the config for multiple endpoints.

Checklist

  • My changes have passed unit tests and have been tested E2E in an example project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant