DXE-3547 Merge pull request #199 from akamai/release/v7.6.1

Release/v7.6.1
akamai · Feb 14, 2024 · a944412 · a944412
2 parents 4eba719 + f83132b
commit a944412
Show file tree

Hide file tree

Showing 3 changed files with 60 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # EDGEGRID GOLANG RELEASE NOTES
 
+## 7.6.1 (February 14, 2024)
+
+#### BUG FIXES:
+
+* Edgeworkers
+  * Fixed case when not providing optional `note` field in `ActivateVersion` would cause activation to fail 
+
 ## 7.6.0 (February 8, 2024)
 
 #### FEATURES/ENHANCEMENTS:

diff --git a/pkg/edgeworkers/activations.go b/pkg/edgeworkers/activations.go
@@ -50,7 +50,7 @@ type (
 	ActivateVersion struct {
 		Network ActivationNetwork `json:"network"`
 		Version string            `json:"version"`
-		Note    string            `json:"note"`
+		Note    string            `json:"note,omitempty"`
 	}
 
 	// ActivationNetwork represents available activation network types

diff --git a/pkg/edgeworkers/activations_test.go b/pkg/edgeworkers/activations_test.go
@@ -3,6 +3,7 @@ package edgeworkers
 import (
 	"context"
 	"errors"
+	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
 	"regexp"
@@ -275,22 +276,25 @@ func TestGetActivation(t *testing.T) {
 
 func TestActivateVersion(t *testing.T) {
 	tests := map[string]struct {
-		params           ActivateVersionRequest
-		responseStatus   int
-		responseBody     string
-		expectedPath     string
-		expectedResponse *Activation
-		withError        error
+		params              ActivateVersionRequest
+		responseStatus      int
+		responseBody        string
+		expectedPath        string
+		expectedRequestBody string
+		expectedResponse    *Activation
+		withError           error
 	}{
 		"200 OK": {
 			params: ActivateVersionRequest{
 				EdgeWorkerID: 42,
 				ActivateVersion: ActivateVersion{
 					Network: "STAGING",
 					Version: "1",
+					Note:    "activation note1",
 				},
 			},
-			responseStatus: http.StatusCreated,
+			expectedRequestBody: `{"network":"STAGING","version":"1","note":"activation note1"}`,
+			responseStatus:      http.StatusCreated,
 			responseBody: `
 {
 	"edgeWorkerId": 42,
@@ -318,6 +322,41 @@ func TestActivateVersion(t *testing.T) {
 				Note:             "activation note1",
 			},
 		},
+		"200 without note": {
+			params: ActivateVersionRequest{
+				EdgeWorkerID: 42,
+				ActivateVersion: ActivateVersion{
+					Network: "STAGING",
+					Version: "1",
+				},
+			},
+			expectedRequestBody: `{"network":"STAGING","version":"1"}`,
+			responseStatus:      http.StatusCreated,
+			responseBody: `
+{
+	"edgeWorkerId": 42,
+	"version": "1",
+	"activationId": 1,
+	"accountId": "B-M-1KQK3WU",
+	"status": "PRESUBMIT",
+	"network": "STAGING",
+	"createdBy": "jsmith",
+	"createdTime": "2018-07-09T08:13:54Z",
+	"lastModifiedTime": "2018-07-09T08:35:02Z"
+}`,
+			expectedPath: "/edgeworkers/v1/ids/42/activations",
+			expectedResponse: &Activation{
+				AccountID:        "B-M-1KQK3WU",
+				ActivationID:     1,
+				CreatedBy:        "jsmith",
+				CreatedTime:      "2018-07-09T08:13:54Z",
+				EdgeWorkerID:     42,
+				LastModifiedTime: "2018-07-09T08:35:02Z",
+				Network:          "STAGING",
+				Status:           "PRESUBMIT",
+				Version:          "1",
+			},
+		},
 		"500 internal server error": {
 			params: ActivateVersionRequest{
 				EdgeWorkerID: 42,
@@ -374,6 +413,12 @@ func TestActivateVersion(t *testing.T) {
 				w.WriteHeader(test.responseStatus)
 				_, err := w.Write([]byte(test.responseBody))
 				assert.NoError(t, err)
+
+				if len(test.expectedRequestBody) > 0 {
+					body, err := ioutil.ReadAll(r.Body)
+					require.NoError(t, err)
+					assert.Equal(t, test.expectedRequestBody, string(body))
+				}
 			}))
 			client := mockAPIClient(t, mockServer)
 			result, err := client.ActivateVersion(context.Background(), test.params)