Change the way the Compose interop works to avoid Android 12 bug #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2024 13:01
…unction that looked like this (in decompiled dex bytecode)
```
public static final ComposeEpoxyModel composeEpoxyModel(String id, Object[] keys, Function2<? super Composer, ? super Integer, Unit> composeFunction) {
...
ComposeEpoxyModel $this$composeEpoxyModel_u24lambda_u240 = new ComposeEpoxyModel(Arrays.copyOf(keys, keys.length), composeFunction);
$this$composeEpoxyModel_u24lambda_u240.id(id);
return $this$composeEpoxyModel_u24lambda_u240;
}
```
this would trigger a ART bug in the (non mainline patched version of Android 12) to optimize the this line
```
$this$composeEpoxyModel_u24lambda_u240.id(id);
```
and lead to crashes on Android 12.
More background at:
#1199 and
https://issuetracker.google.com/issues/197818595
This works around this issue by making sure that the creation, setting the id and adding to the controller of a ComposeEpoxyModelis happening in the same location in compiled bytecode.
Note: If you run R8 with optimization enabled, outlining might still outline some of that inlined code again and thus still cause this probblem but that is a different issue that can be dealed with by disabling outlining or all optimization.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the
composeEpoxyModelfunction was written it would create a function that looked like this (in decompiled dex bytecode (for readability compiled to Java))this would trigger a ART bug in the (non mainline patched version of Android 12) to optimize the this line away
and lead to crashes on Android 12.
More background at:
#1199 and
https://issuetracker.google.com/issues/197818595
This works around this issue by making sure that the creation, setting the id and adding to the controller of a
ComposeEpoxyModelis happening in the same location in compiled bytecode.Note: If you run R8 with optimization enabled, the method outlining optimization might still outline some of that inlined code again and thus still cause this problem but that is a different issue that can be dealt with by disabling outlining or all optimization.