Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create style guide #103

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Create style guide #103

wants to merge 11 commits into from

Conversation

makahmad
Copy link
Contributor

No description provided.

@makahmad makahmad requested a review from a team as a code owner November 14, 2022 19:58
@google-cla
Copy link

google-cla bot commented Nov 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rofrankel rofrankel marked this pull request as draft November 14, 2022 20:03
Copy link

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and thank you for this contribution.

I suggested a few minor changes but I would not hold up merging for any of these.

aip/general/0008/aip.md Outdated Show resolved Hide resolved
aip/general/0008/aip.md Outdated Show resolved Hide resolved
aip/general/0008/aip.md Show resolved Hide resolved
aip/general/0008/aip.md Show resolved Hide resolved
aip/general/0008/aip.md Outdated Show resolved Hide resolved
aip/general/0008/aip.md Outdated Show resolved Hide resolved
aip/general/0008/aip.md Outdated Show resolved Hide resolved
aip/general/0008/aip.md Outdated Show resolved Hide resolved
aip/general/0008/aip.md Outdated Show resolved Hide resolved
aip/general/0008/aip.md Outdated Show resolved Hide resolved
aip/general/0008/aip.md Outdated Show resolved Hide resolved
@makahmad makahmad marked this pull request as ready for review November 18, 2022 22:46
rofrankel and others added 2 commits November 22, 2022 13:05
Co-authored-by: Richard Frankel <[email protected]>
Co-authored-by: Richard Frankel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants