Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: add punkt_tab to nltk LookupError check #1319

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Lopa10ko
Copy link
Collaborator

This is a 🐛 bug fix.

Summary

  • Added the punkt_tab to the list of required NLTK resources.

Context

fixes recent integration tests failures:
https://github.com/aimclub/FEDOT/actions/runs/10339781677

@Lopa10ko Lopa10ko self-assigned this Aug 12, 2024
@Lopa10ko
Copy link
Collaborator Author

@Lopa10ko Lopa10ko requested a review from DRMPN August 12, 2024 12:16
Copy link
Contributor

Code has no PEP8 errors!

Copy link
Collaborator

@DRMPN DRMPN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (3d49382) to head (d94f743).

Files Patch % Lines
...lementations/data_operations/text_preprocessing.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
- Coverage   80.16%   80.13%   -0.03%     
==========================================
  Files         146      146              
  Lines       10278    10278              
==========================================
- Hits         8239     8236       -3     
- Misses       2039     2042       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lopa10ko Lopa10ko merged commit 39e960c into master Aug 12, 2024
10 checks passed
@Lopa10ko Lopa10ko deleted the fix-nltk-punkt-lookup branch September 26, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants