-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #1296 #1312
Fix for #1296 #1312
Conversation
All PEP8 errors has been fixed, thanks ❤️ Comment last updated at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
=======================================
Coverage 79.93% 79.94%
=======================================
Files 146 146
Lines 10097 10100 +3
=======================================
+ Hits 8071 8074 +3
Misses 2026 2026 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Думаю, что стоит добавить тест для этого случая.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
можно вместо нового теста при возможности добавить сценарий к уже существующим в test/unit/data/test_data_split
This is a 🐛 bug fix.
Summary
There was not enough copying for encoded categorical features during data spliting.
Fixes #1296