Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix of fit time estimation for initial assumption #1309

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Conversation

nicl-nno
Copy link
Collaborator

@nicl-nno nicl-nno commented Jul 2, 2024

Now estimation is cv_folds-aware.

Copy link

docu-mentor bot commented Jul 2, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

Copy link
Contributor

github-actions bot commented Jul 2, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

@Lopa10ko
Copy link
Collaborator

Lopa10ko commented Jul 2, 2024

/fix-pep8

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (cd915a8) to head (9564e64).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
+ Coverage   79.88%   79.95%   +0.07%     
==========================================
  Files         146      146              
  Lines       10065    10097      +32     
==========================================
+ Hits         8040     8073      +33     
+ Misses       2025     2024       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicl-nno nicl-nno requested review from Lopa10ko and DRMPN July 3, 2024 12:48
@Lopa10ko
Copy link
Collaborator

Lopa10ko commented Jul 3, 2024

вроде норм, к функциональности решения вопросов нет.

@nicl-nno nicl-nno merged commit e0b4ee7 into master Jul 4, 2024
10 checks passed
@nicl-nno nicl-nno deleted the n_folds_hotfix branch July 4, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants