fix: NaNs containing forecast on some ets configs #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lopa10ko
added
bug
|
👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app Simply create a new comment in this PR that says: @docu-mentor run and I will start my analysis. I only look at what you changed @docu-mentor run doc/ README.md In this example, I'll have a look at all files contained in the "doc/" |
|
All PEP8 errors has been fixed, thanks ❤️ Comment last updated at |
nicl-nno
reviewed
May 17, 2024
| # if convergence warning is caught, switch to default ETSModel | ||
| self.model.fit(disp=False) | ||
| except ConvergenceWarning as e: | ||
| self.params.update(**{'error': 'add', 'trend': None, 'seasonal': None}) |
There was a problem hiding this comment.
Вроде в таком случае надо ещё в model_repository.json к ets добавить тег correct_params
nicl-nno
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
closes #1285