Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old pep8 errors #1244

Merged
merged 19 commits into from
Feb 8, 2024
Merged

Fix old pep8 errors #1244

merged 19 commits into from
Feb 8, 2024

Conversation

DRMPN
Copy link
Collaborator

@DRMPN DRMPN commented Jan 10, 2024

This is a 🔨 code refactoring.

Summary

Fix old pep8 errors in python files.

Context

PR #1225

@DRMPN DRMPN self-assigned this Jan 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5efd0fb) 79.84% compared to head (459041e) 79.84%.

Files Patch % Lines
...ion_intervals/solvers/mutation_of_best_pipeline.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1244   +/-   ##
=======================================
  Coverage   79.84%   79.84%           
=======================================
  Files         150      150           
  Lines       10322    10322           
=======================================
  Hits         8242     8242           
  Misses       2080     2080

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DRMPN
Copy link
Collaborator Author

DRMPN commented Jan 10, 2024

/fix-pep8

@DRMPN
Copy link
Collaborator Author

DRMPN commented Jan 10, 2024

/fix-pep8

@DRMPN DRMPN mentioned this pull request Jan 10, 2024
Merged
@DRMPN
Copy link
Collaborator Author

DRMPN commented Jan 10, 2024

/fix-pep8

@DRMPN DRMPN mentioned this pull request Jan 10, 2024
Merged
@DRMPN
Copy link
Collaborator Author

DRMPN commented Jan 10, 2024

/fix-pep8

1 similar comment
@DRMPN
Copy link
Collaborator Author

DRMPN commented Jan 10, 2024

/fix-pep8

@DRMPN DRMPN requested a review from nicl-nno January 10, 2024 11:07
@nicl-nno nicl-nno requested a review from Nunkyl January 10, 2024 13:10
@DRMPN DRMPN requested a review from MorrisNein January 10, 2024 14:08
MorrisNein
MorrisNein reviewed Jan 10, 2024
View reviewed changes
fedot/core/pipelines/prediction_intervals/solvers/mutation_of_best_pipeline.py Outdated
except:
except BaseException:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот тут BaseException формально верно, потому не изменяет поведение. Но на деле должно быть Exception, чтобы допустить, например, KeyboardInterrupt. Это имеется в виду в подавляющем большинстве случаев. Если можно настроить автозамену на Exception, было бы круто

Copy link
Collaborator Author

@DRMPN DRMPN Jan 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может except без всего это синтаксический сахар для except BaseException, поэтому он так и сделал? Если это так, тогда нужно самим явно прописать Exception.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

...ore/operations/evaluation/operation_implementations/models/ts_implementations/statsmodels.py Outdated Show resolved Hide resolved
test/unit/pipelines/test_pipeline_node_factory.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented Feb 3, 2024 •
edited
Loading

Hello @DRMPN! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-02-08 08:42:45 UTC

@DRMPN
Copy link
Collaborator Author

DRMPN commented Feb 3, 2024

/fix-pep8

@DRMPN
Copy link
Collaborator Author

DRMPN commented Feb 3, 2024

/fix-pep8

@DRMPN
Copy link
Collaborator Author

DRMPN commented Feb 3, 2024

/fix-pep8

@DRMPN DRMPN merged commit 78a8924 into master Feb 8, 2024
7 checks passed
@DRMPN DRMPN deleted the patch-old-pep8-errors branch August 28, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicl-nno nicl-nno nicl-nno approved these changes

@MorrisNein MorrisNein MorrisNein approved these changes

@Nunkyl Nunkyl Awaiting requested review from Nunkyl

Assignees

@DRMPN DRMPN

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DRMPN @pep8speaks @nicl-nno @Nunkyl @MorrisNein