1211-fix #1213
1211-fix #1213
Conversation
|
Hello @kasyanovse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-04 09:57:57 UTC |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
+ Coverage 79.27% 79.31% +0.03%
==========================================
Files 145 145
Lines 10048 10043 -5
==========================================
Hits 7966 7966
+ Misses 2082 2077 -5 ☔ View full report in Codecov by Sentry. |
| reduce_function = lambda x, y: x | y | ||
| return list(reduce(reduce_function, data)) | ||
|
|
||
| tags = extract_metadata_from_pipeline('tags') | ||
| input_types = extract_metadata_from_pipeline('input_types', | ||
| node_filter=lambda node: node.is_primary, | ||
| reduce_function=lambda x, y: x & y) |
There was a problem hiding this comment.
Тут вместо lambda можно использовать эти функции:
from operator import and_, or_
| def extract_metadata_from_pipeline(attr_name: str, | ||
| node_filter: Optional[Callable[[PipelineNode], bool]] = None, | ||
| reduce_function: Optional[Callable[[List[Set]], Set]] = None): |
There was a problem hiding this comment.
Очень не хватает докстринги для понимания параметров
Fix #1211