Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch OneHotEncoder to LabelEncoder #1196

Closed
wants to merge 8 commits into from
Closed

Switch OneHotEncoder to LabelEncoder #1196

wants to merge 8 commits into from

Conversation

aPovidlo
Copy link
Collaborator

Change default categories encoder as LabelEncoder in preprocessing

@aPovidlo aPovidlo self-assigned this Nov 13, 2023
Copy link
Collaborator

@valer1435 valer1435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Стоит проверить, работает или нет. Если действительно работает, то хорошо.

@valer1435
Copy link
Collaborator

Только в мастер это не стоит лить, лучше в отдельную ветку

@aPovidlo
Copy link
Collaborator Author

Стоит проверить, работает или нет. Если действительно работает, то хорошо.

Там тесты падали. Как я думал, ветку будут использовать отдельно в экспериментах прежде чем лить в мастер

@pep8speaks
Copy link

pep8speaks commented Nov 13, 2023

Hello @aPovidlo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 5:1: F401 'sklearn.preprocessing.LabelEncoder' imported but unused

Line 13:1: E302 expected 2 blank lines, found 1
Line 16:1: E305 expected 2 blank lines after class or function definition, found 1

Line 6:1: F401 'fedot.core.data.merge.data_merger.DataMerger' imported but unused

Comment last updated at 2023-11-21 13:51:32 UTC

@nicl-nno
Copy link
Collaborator

В целом те тесты где проверяется размерность выхода можно просто отключить в этой ветке.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70fc033) 79.49% compared to head (ffbf306) 79.39%.
Report is 2 commits behind head on master.

❗ Current head ffbf306 differs from pull request most recent head ee20efd. Consider uploading reports for the commit ee20efd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
- Coverage   79.49%   79.39%   -0.10%     
==========================================
  Files         145      145              
  Lines       10022    10022              
==========================================
- Hits         7967     7957      -10     
- Misses       2055     2065      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aPovidlo
Copy link
Collaborator Author

aPovidlo commented Dec 8, 2023

Migrate to #1004 Preprocessor acceleration

@aPovidlo aPovidlo closed this Dec 8, 2023
@aPovidlo aPovidlo deleted the ohe_to_le branch December 28, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants