Lagged implementation speedup #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
А есть оценка насколько это ускоряет? |
|
Тесты на произвольных данных. исправленный код находится в функции Старый вариант. Новый вариант. |
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
=======================================
Coverage 78.53% 78.53%
=======================================
Files 131 131
Lines 9359 9360 +1
=======================================
+ Hits 7350 7351 +1
Misses 2009 2009
|
|
Здорово! Да наверное в тесте нет нужды, время сложно оценивать. |
nicl-nno
reviewed
Aug 10, 2023
| @@ -841,7 +841,8 @@ def prepare_target(all_idx, idx, features_columns: np.array, target, forecast_le | |||
| idx = idx[: -1] | |||
|
|
|||
| # Update target (clip first "window size" values) | |||
| row_nums = [list(all_idx).index(i) for i in idx] | |||
| index_hash_table = {val: i for i, val in enumerate(all_idx)} | |||
There was a problem hiding this comment.
Можешь оставить в комментарии пометку что такая реализация критична для производительности.
nicl-nno
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line in code in lagged implementation spends more than 95% of lagged implementation evaluation time (in my case).
Fixed it.