Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize static folder and add pre-loaded stylesheets #772

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Jul 11, 2024

This PR reorganizes the static folder with dedicated subfolders for templates and styles. The styles folder holds stylesheets that are automatically loaded (using a new aiidalab-widgets-base utility function) in the main notebook.

Dependency

This PR depends on aiidalab/aiidalab-widgets-base#624, which introduces the load_css utility

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.16%. Comparing base (772878b) to head (65327d9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/result/workchain_viewer.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   68.16%   68.16%           
=======================================
  Files          48       48           
  Lines        4159     4159           
=======================================
  Hits         2835     2835           
  Misses       1324     1324           
Flag Coverage Δ
python-3.11 68.16% <75.00%> (ø)
python-3.9 68.19% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass
Copy link
Member Author

@danielhollas, @superstar54, @yakutovicha the silicon select and confirm test is timing out. I tried to commit an increase to the timeout (to 60s), but it still is not enough. I'm surprised the new CSS loading or the reorganization of static files could cause such a delay. Could someone please give it a look?

@edan-bainglass
Copy link
Member Author

Resolved. Thanks @superstar54 🙂

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, only one comment about the outdated README file. Leaving approval to others.

qe.ipynb Show resolved Hide resolved
src/aiidalab_qe/app/static/styles/README.md Outdated Show resolved Hide resolved
src/aiidalab_qe/app/static/styles/custom.css Show resolved Hide resolved
@edan-bainglass edan-bainglass merged commit e492404 into main Sep 5, 2024
12 checks passed
@edan-bainglass edan-bainglass deleted the static branch September 5, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants