-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base image to python-3.11.3 #455
base: main
Are you sure you want to change the base?
Conversation
53fbd49
to
c644ba0
Compare
e0bdb6e
to
5ed097a
Compare
6740395
to
e52ca1e
Compare
Blocked on aiidalab/aiidalab#428 |
Hi @danielhollas, I reconsidered if use jupyter stack as the base image is a good option, instead if we move to using aiida-core images could gaining more flexibility. Major two reasons are:
Let me know your opinion. |
Blocked on aiidalab/aiidalab#429 @unkcpz I've created #471, we shouldn't be discussing these foundational thing in PRs. |
Yep, just came to this PR when I start to try with notebook v7. Great you open an issue for this, I agree it is premature to move to that, this is just things come to my mind and want to get to know your opinions. Let’s have follow up discussion on the issue you opened.
Gesendet von Outlook für iOS<https://aka.ms/o0ukef>
…________________________________
Von: Daniel Hollas ***@***.***>
Gesendet: Saturday, June 22, 2024 7:12:18 PM
An: aiidalab/aiidalab-docker-stack ***@***.***>
Cc: Jusong Yu ***@***.***>; Mention ***@***.***>
Betreff: Re: [aiidalab/aiidalab-docker-stack] Update base image to python-3.10.11 (PR #455)
Blocked on aiidalab/aiidalab#429<aiidalab/aiidalab#429>
@unkcpz<https://github.com/unkcpz> I've created #471<#471>, we shouldn't be discussing these foundational thing in PRs.
—
Reply to this email directly, view it on GitHub<#455 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDMFRJIEIKK6TADBBHT2JLZIWV7FAVCNFSM6AAAAABHVEF3JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUGEYTGMJSGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Yeah, if you want to start to play with NB7, you can start with this PR and set |
72023df
to
01e7258
Compare
mamba install --yes \ | ||
aiida-core==${AIIDA_VERSION} \ | ||
mamba-bash-completion \ | ||
traitlets=5.9.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base image already comes with traitlets==5.9.0
Closes #265
NOTE: Upgrading Python is a breaking changes, since existing App need to be reinstalled due to #317