Skip to content

Commit

Permalink
Downgrade nw.js to 0.55.0 (experimental).
Browse files Browse the repository at this point in the history
This is the last version which doesn't have the nwworkingdir bug on
Linux which causes file dialogs to open in the wrong locations. It also
seems to work just as well (or at least not any worse) than 0.67.0 on
Mac and Windows.

The only downside is that 0.55.0 still has the dark mode bug on Linux
(#42); Mac and Windows seem to
be fine. But this is a cosmetic issue which can be worked around by
adjusting the desktop theme, while the nwworkingdir bug breaks important
functionality and has no known work-around. So I think that fixing the
latter at the cost of breaking dark mode is the most sensible choice.

Note that if you absolutely need to have dark mode working, you can now
just use the new patch-nwjs.sh script to patch your Purr Data
installation to use 0.67.0 again (the former default).
  • Loading branch information
agraef committed Aug 21, 2024
1 parent 8fc1eca commit c367e16
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion debuild/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ debdist = purr-data-$(debversion)
# nw.js sdk
# NOTE: arm packages need some special-casing, since they are released
# separately, and the version numbers do not always match up.
nwjsver = 0.67.0
nwjsver = 0.55.0
nwjspkg = nwjs-sdk-v$(nwjsver)-linux
nwjsver_arm = 0.27.6
nwjspkg_arm = nwjs-sdk-v$(nwjsver_arm)-linux
Expand Down
2 changes: 1 addition & 1 deletion debuild/debian/rules
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1

nwjsver = 0.67.0
nwjsver = 0.55.0
nwjspkg = nwjs-sdk-v$(nwjsver)-linux
nwjsdir = nwjs-sdk-v$(nwjsver)-linux

Expand Down
10 changes: 6 additions & 4 deletions l2ork_addons/tar_em_up.sh
Original file line number Diff line number Diff line change
Expand Up @@ -217,19 +217,21 @@ if [ ! -d "../pd/nw/nw" ]; then
# work on newer macOS versions. Note that at present only
# Intel builds are supported, but these should also work on
# Apple Silicon via Rosetta 2.
nwjs_version="v${nwjsver:-0.67.0}"
nwjs_version="v${nwjsver:-0.55.0}"
elif [[ $os == "win" || $os == "win64" ]]; then
# same version works on Windows, too
nwjs_version="v${nwjsver:-0.67.0}"
nwjs_version="v${nwjsver:-0.55.0}"
elif [ $arch == "arm" ]; then
# rpi-- only 0.27.6 is available atm
nwjs_version="v0.27.6"
elif [ $arch == "arm64" ]; then
# dito for rpi arm64-- 0.23.7 version
nwjs_version="v0.23.7"
else
# default for Linux -- same as Mac and Windows for now
nwjs_version="v${nwjsver:-0.67.0}"
# default for Linux -- same as Mac and Windows; note that
# anything past 0.55.0 suffers from the nwworkingdir bug which
# makes file dialogs open in the wrong locations
nwjs_version="v${nwjsver:-0.55.0}"
fi

nwjs="nwjs-sdk"
Expand Down

0 comments on commit c367e16

Please sign in to comment.