Minor Improvements #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy birthday, dear pull request! :-) 🎂 |
| @@ -1,3 +1,5 @@ | |||
| ### THIS FILE IS MANAGED BY ANSIBLE -- DO NOT EDIT! ### | |||
There was a problem hiding this comment.
Isn't that already done in our ansible repos? I remember the header looking like {{ ansible_managed }}.
There was a problem hiding this comment.
Or does that only cover ansible.git, but not the ansible-mta submodule?
There was a problem hiding this comment.
Usually, I would also vote for {{ ansible_managed }}. There are two reason for not using it:
- It only works in templates and not in static files.
- All other roles in our ansible repo use this static line. I just copied it. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
### THIS FILE IS MANAGED BY ANSIBLE -- DO NOT EDIT! ###to all of the files.Sets
/etc/mailnametomta_override_hostnameorinventory_hostname(if the former is not specified; the same logic is used in posfix'smain.cf).