Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust Composable function signature to make source mandatory #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ For Jetpack Compose, utilize PdfRendererViewCompose:

```kotlin
PdfRendererViewCompose(
url = "your_pdf_url_here",
source = PdfSource.Remote("your_pdf_url_here"),
lifecycleOwner = LocalLifecycleOwner.current
)
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import androidx.compose.ui.platform.LocalLifecycleOwner
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.rajat.pdfviewer.PdfRendererView
import com.rajat.pdfviewer.PdfSource
import com.rajat.pdfviewer.compose.PdfRendererViewCompose
import com.rajat.sample.pdfviewer.ui.theme.AndroidpdfviewerTheme
import java.io.File
Expand Down Expand Up @@ -102,8 +103,8 @@ fun MyPdfScreenFromUri(modifier: Modifier = Modifier) {
fun MyPdfScreenFromUri(uri: Uri, modifier: Modifier = Modifier) {
val lifecycleOwner = LocalLifecycleOwner.current
PdfRendererViewCompose(
source = PdfSource.LocalUri(uri),
modifier = modifier,
uri = uri,
lifecycleOwner = lifecycleOwner,
statusCallBack = object : PdfRendererView.StatusCallBack {
override fun onPdfLoadStart() {
Expand Down Expand Up @@ -137,8 +138,8 @@ fun MyPdfScreenFromUri(uri: Uri, modifier: Modifier = Modifier) {
fun MyPdfScreenFromUrl(url: String, modifier: Modifier = Modifier) {
val lifecycleOwner = LocalLifecycleOwner.current
PdfRendererViewCompose(
source = PdfSource.Remote(url),
modifier = modifier,
url = url,
lifecycleOwner = lifecycleOwner,
statusCallBack = object : PdfRendererView.StatusCallBack {
override fun onPdfLoadStart() {
Expand Down Expand Up @@ -174,7 +175,7 @@ fun MyPdfScreenFromFile() {
val lifecycleOwner = LocalLifecycleOwner.current
val pdfFile = File("path/to/your/file.pdf") // Replace with your file path
PdfRendererViewCompose(
file = pdfFile,
source = PdfSource.LocalFile(pdfFile),
lifecycleOwner = lifecycleOwner
)
}
Expand Down
10 changes: 10 additions & 0 deletions pdfViewer/src/main/java/com/rajat/pdfviewer/PdfSource.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package com.rajat.pdfviewer

import android.net.Uri
import java.io.File

sealed interface PdfSource {
data class Remote(val url: String) : PdfSource
data class LocalFile(val file: File) : PdfSource
data class LocalUri(val uri: Uri) : PdfSource
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.rajat.pdfviewer.compose

import android.net.Uri
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.LocalLifecycleOwner
Expand All @@ -9,14 +8,12 @@ import androidx.lifecycle.LifecycleOwner
import androidx.lifecycle.lifecycleScope
import com.rajat.pdfviewer.HeaderData
import com.rajat.pdfviewer.PdfRendererView
import java.io.File
import com.rajat.pdfviewer.PdfSource

@Composable
fun PdfRendererViewCompose(
source: PdfSource,
modifier: Modifier = Modifier,
url: String? = null,
file: File? = null,
uri: Uri? = null,
headers: HeaderData = HeaderData(),
lifecycleOwner: LifecycleOwner = LocalLifecycleOwner.current,
statusCallBack: PdfRendererView.StatusCallBack? = null
Expand All @@ -29,12 +26,16 @@ fun PdfRendererViewCompose(
if (statusCallBack != null) {
statusListener = statusCallBack
}
if (file != null) {
initWithFile(file)
} else if (url != null) {
initWithUrl(url, headers, lifecycleScope, lifecycleOwner.lifecycle)
} else if (uri != null) {
initWithUri(uri)

when (source) {
is PdfSource.LocalFile -> initWithFile(source.file)
is PdfSource.LocalUri -> initWithUri(source.uri)
is PdfSource.Remote -> initWithUrl(
source.url,
headers,
lifecycleScope,
lifecycleOwner.lifecycle
)
}
}
},
Expand Down