Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ioutil #630

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Removed ioutil #630

merged 2 commits into from
Jul 25, 2023

Conversation

vania-pooh
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0670bf2) 5.88% compared to head (bfee8da) 5.88%.

❗ Current head bfee8da differs from pull request most recent head 3e626b1. Consider uploading reports for the commit 3e626b1 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #630   +/-   ##
======================================
  Coverage    5.88%   5.88%           
======================================
  Files           8       8           
  Lines         832     832           
======================================
  Hits           49      49           
  Misses        776     776           
  Partials        7       7           
Flag Coverage Δ
go 5.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
build/base.go 8.73% <0.00%> (ø)
build/file.go 21.52% <0.00%> (ø)
build/firefox.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vania-pooh vania-pooh merged commit 8dd2917 into aerokube:master Jul 25, 2023
1 check passed
@lionelnicolas
Copy link

It looks like few references of ioutil have been forgotten here:

image

This prevent the build to succeed:

go: downloading github.com/aandryashin/matchers v0.0.0-20161126170413-435295ea180e
go: downloading github.com/mafredri/cdp v0.23.4
go: downloading github.com/gorilla/websocket v1.4.2
# github.com/aerokube/devtools [github.com/aerokube/devtools.test]
./devtools_test.go:178:13: undefined: ioutil
./devtools_test.go:183:2: undefined: ioutil
FAIL	github.com/aerokube/devtools [build failed]

vania-pooh added a commit to vania-pooh/images that referenced this pull request Aug 2, 2023
@vania-pooh
Copy link
Member Author

Fixed.

vania-pooh added a commit that referenced this pull request Aug 2, 2023
Removed ioutil from devtools test (related to #630)
@lionelnicolas
Copy link

Fixed.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants