Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(revisions): adopt aep-162 revisions #200

Merged
merged 13 commits into from
Sep 25, 2024
Merged

feat(revisions): adopt aep-162 revisions #200

merged 13 commits into from
Sep 25, 2024

Commits on Sep 14, 2024

  1. feat(revisions): adopt aep-162 revisions 

    Adapted from aip.dev/162.

list of changes include:

- changing references to "name" to "path".
- minor formatting changes like consolidating proto examples so we can minimize the proto/openapi tabs.
- removed some sections from rationale that spoke to aip.dev more than aeps, and didn't provide valuable context (like the existence of "tag" in older versions of the pattern).
- added openapi schemas.
    @toumorokoshi
    toumorokoshi committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    0a97a1a View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Richard Frankel <[email protected]>
    @toumorokoshi @rofrankel
    toumorokoshi and rofrankel committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    91f7081 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Richard Frankel <[email protected]>
    @toumorokoshi @rofrankel
    toumorokoshi and rofrankel committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    0f1fc7d View commit details
    Browse the repository at this point in the history

  4. addressing comments

    @toumorokoshi
    toumorokoshi committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    9ee23af View commit details
    Browse the repository at this point in the history

  5. addressing more comments

    @toumorokoshi
    toumorokoshi committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    038d95e View commit details
    Browse the repository at this point in the history

  6. addressing comments

    @toumorokoshi
    toumorokoshi committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7007c5a View commit details
    Browse the repository at this point in the history

  7. snapshost -> resource

    @toumorokoshi
    toumorokoshi committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    4b7ec53 View commit details
    Browse the repository at this point in the history

  8. addressing feedback

    @toumorokoshi
    toumorokoshi committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    dfdf669 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: dv-stewarts <[email protected]>
    @toumorokoshi @dv-stewarts
    toumorokoshi and dv-stewarts committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b5b96ca View commit details
    Browse the repository at this point in the history

  10. addressing feedback.

    @toumorokoshi
    toumorokoshi committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7ffc61d View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Richard Frankel <[email protected]>
    @toumorokoshi @rofrankel
    toumorokoshi and rofrankel authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fe8fe11 View commit details
    Browse the repository at this point in the history

  2. addressing comments from code review

    @toumorokoshi
    toumorokoshi committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1ad1524 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Richard Frankel <[email protected]>
    @toumorokoshi @rofrankel
    toumorokoshi and rofrankel authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4390378 View commit details
    Browse the repository at this point in the history