Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: concurrent modification exception in kotlin 1.9.20 and compose 1.5.10 #245

Merged
merged 3 commits into from
Nov 5, 2023
Merged

fix: concurrent modification exception in kotlin 1.9.20 and compose 1.5.10 #245

merged 3 commits into from
Nov 5, 2023

Conversation

DevSrSouza
Copy link
Collaborator

fixes #244

@DevSrSouza DevSrSouza mentioned this pull request Nov 3, 2023
Closed
Syer10
Syer10 reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@Syer10 Syer10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to copy them before using them

voyager-core/src/nativeMain/kotlin/cafe.adriel.voyager.core/concurrent/ThreadSafeMap.native.kt Outdated Show resolved Hide resolved
voyager-core/src/nativeMain/kotlin/cafe.adriel.voyager.core/concurrent/ThreadSafeMap.native.kt Outdated Show resolved Hide resolved
voyager-core/src/nativeMain/kotlin/cafe.adriel.voyager.core/concurrent/ThreadSafeMap.native.kt Outdated Show resolved Hide resolved
@DevSrSouza
Copy link
Collaborator Author

Done! Thanks for the suggestion @Syer10

@DevSrSouza DevSrSouza merged commit 68381cc into main Nov 5, 2023
1 check passed
@DevSrSouza DevSrSouza deleted the fix/concurrent-modification branch November 5, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syer10 Syer10 Syer10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Crashes on iOS when navigating, after upgrading to Kotlin 1.9.20
2 participants
@DevSrSouza @Syer10