Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for multi-byte characters #27

Merged
merged 11 commits into from
Sep 27, 2023
Merged

Fix support for multi-byte characters #27

merged 11 commits into from
Sep 27, 2023

Conversation

adrg
Copy link
Owner

@adrg adrg commented Sep 27, 2023

  • Fix support for multibyte characters throughout the package.
  • Improve test cases.

Addresses issue #18.

@adrg adrg changed the title Metrics improvements Fix support for multi-byte runes Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7ba2633) 0.00% compared to head (f86c21b) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##           master       #27        +/-   ##
=============================================
+ Coverage        0   100.00%   +100.00%     
=============================================
  Files           0        13        +13     
  Lines           0       466       +466     
=============================================
+ Hits            0       466       +466     
Files Coverage Δ
internal/stringutil/stringutil.go 100.00% <100.00%> (ø)
metrics/jaro.go 100.00% <100.00%> (ø)
metrics/levenshtein.go 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrg adrg changed the title Fix support for multi-byte runes Fix support for multi-byte characters Sep 27, 2023
@adrg adrg merged commit f9dd097 into master Sep 27, 2023
5 checks passed
@adrg adrg deleted the metrics-improvements branch September 27, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant