Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
40 implement a secure key storage functionality for the pop server #176
base: main
Are you sure you want to change the base?
40 implement a secure key storage functionality for the pop server #176
Changes from 7 commits
96e069d
b78ba29
3ca8d7e
0a3aa61
acd5d64
6fd582b
e169c08
f069f43
bcb84be
8fe00a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your errors need to be more descriptive:
Check warning on line 26 in crates/keystore/src/lib.rs
GitHub Actions / Build and Test
Check warning on line 26 in crates/keystore/src/lib.rs
GitHub Actions / Build and Test
Check warning on line 30 in crates/keystore/src/lib.rs
GitHub Actions / Build and Test
Check warning on line 30 in crates/keystore/src/lib.rs
GitHub Actions / Build and Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this struct? It is not constructed anywhere.
Check warning on line 36 in crates/keystore/src/lib.rs
GitHub Actions / Build and Test
Check warning on line 36 in crates/keystore/src/lib.rs
GitHub Actions / Build and Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you map the error when not going to propagate it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand what you are trying to do here. Your encrypt function is not used anywhere, I suppose that you created it to encrypt the keys before storing them? If that's the purpose, then how are you going to decrypt them later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functions you created are not used, where do you call them ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also provide tests for your functions