Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACNA-3231 | E2e tests failure #815

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

amulyakashyap09
Copy link
Contributor

Description

  • a scenario where user does not have login but deployment creds
  • if Audit service is unavailable then deploy/undeploy was failing

Related Issue

ACNA-3231

Motivation and Context

How Has This Been Tested?

  • Tested locally
  • Unit Tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b36d06) to head (9f4337c).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #815   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3323      3327    +4     
  Branches       641       641           
=========================================
+ Hits          3323      3327    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/lib/app-helper.js Outdated Show resolved Hide resolved
src/lib/audit-logger.js Outdated Show resolved Hide resolved
src/commands/app/deploy.js Outdated Show resolved Hide resolved
src/commands/app/deploy.js Outdated Show resolved Hide resolved
src/commands/app/deploy.js Show resolved Hide resolved
src/commands/app/undeploy.js Outdated Show resolved Hide resolved
src/commands/app/undeploy.js Outdated Show resolved Hide resolved
src/commands/app/undeploy.js Outdated Show resolved Hide resolved
test/commands/app/undeploy.test.js Outdated Show resolved Hide resolved
test/commands/lib/audit-logger.test.js Outdated Show resolved Hide resolved
Copy link
Member

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip all this findCommand, execa call command work, it is not required, just use aioConfig directly as is already done throughout the code.

src/lib/app-helper.js Outdated Show resolved Hide resolved
AB_APP_ASSETS_DEPLOYED: 'ab_app_assets_deployed',
AB_APP_ASSETS_UNDEPLOYED: 'ab_app_assets_undeployed'
}

const AUDIT_SERVICE_ENPOINTS = {
const AUDIT_SERVICE_ENDPOINTS = {
stage: 'https://adp-auditlog-service-stage.adobeioruntime.net/api/v1/web/audit-log-api/event-post',
prod: 'https://adp-auditlog-service-prod.adobeioruntime.net/api/v1/web/audit-log-api/event-post'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this endpoint is not live it should never appear in a code commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not merge this PR unless prod service is UP for logger Endpoint. Adding the DO_NOT_REMOVE label.

test/commands/app/deploy.test.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants