-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACNA-3231 | E2e tests failure #815
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #815 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 3323 3327 +4
Branches 641 641
=========================================
+ Hits 3323 3327 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip all this findCommand, execa call command work, it is not required, just use aioConfig directly as is already done throughout the code.
AB_APP_ASSETS_DEPLOYED: 'ab_app_assets_deployed', | ||
AB_APP_ASSETS_UNDEPLOYED: 'ab_app_assets_undeployed' | ||
} | ||
|
||
const AUDIT_SERVICE_ENPOINTS = { | ||
const AUDIT_SERVICE_ENDPOINTS = { | ||
stage: 'https://adp-auditlog-service-stage.adobeioruntime.net/api/v1/web/audit-log-api/event-post', | ||
prod: 'https://adp-auditlog-service-prod.adobeioruntime.net/api/v1/web/audit-log-api/event-post' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this endpoint is not live it should never appear in a code commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will not merge this PR unless prod service is UP for logger Endpoint. Adding the DO_NOT_REMOVE label.
Description
Related Issue
ACNA-3231
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: